Conversation
ed6f29d to
b71da84
Compare
Collaborator
|
Commit: 2d546c1
30 interesting tests: 13 RECOVERED, 10 KNOWN, 6 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
andrewnester
approved these changes
Jan 12, 2026
lennartkats-db
requested changes
Jan 13, 2026
Contributor
lennartkats-db
left a comment
There was a problem hiding this comment.
Minor changes requested
| // YAML paths are relative to directory containing YAML file, in this case: | ||
| // DAB YAML is in "./resources/<directoryName>.pipeline.yml" | ||
| // SDP YAML is in "./<pipelineDirectoryPath>/spark-pipeline.yml" | ||
| // NB: all paths are /-based so Windows has the same output |
Contributor
There was a problem hiding this comment.
Nit: that's a lotta comments
Collaborator
Author
There was a problem hiding this comment.
🤷 These are non-AI comments I wrote by hand. I think it's helpful to have them, otherwise, paths are tricky because they are typed as strings and it's hard to follow in which format they are.
Contributor
There was a problem hiding this comment.
I can't even tell anymore 😭 You can keep them
lennartkats-db
approved these changes
Jan 13, 2026
Collaborator
|
Commit: 008b72a
34 interesting tests: 15 RECOVERED, 10 KNOWN, 8 flaky, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add
databricks pipelines generatecommand that generates DAB resources from SDP YAML.generatecommand is tailored tolakeflow-pipelinestemplate wheresrcfolder contains pipeline folders, for example:Usage
Where
src/my_pipeline/sdp-pipeline.yml:Produces
resources/my_pipeline.pipeline.yml:Why
It allows creating DAB YAML for Spark Declarative Pipelines
Tests
Acceptance and unit tests